-
Notifications
You must be signed in to change notification settings - Fork 70
Implement CLI for ingested codeowners #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This requires some backend changes that I proposed on the schema PR, but it might help with testing the implementation.
leonore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotted a mismatch with main!
| query := `mutation DeleteCodeownersFile( | ||
| $repoName: String!, | ||
| ) { | ||
| deleteCodeownersFiles(repositories: [{ | ||
| repoName: $repoName, | ||
| }]) { | ||
| alwaysNil | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this isn't up to date with main anymore, it takes a slice (just in case we wanted an admin UI with it)
go run ./cmd/src codeowners delete -repo 'github.com/leonore/sourcegraph-test'
GraphQL errors: 2 errors occurred:
* {
"locations": [
{
"column": 24,
"line": 4
}
],
"message": "Unknown argument \"repositories\" on field \"deleteCodeownersFiles\" of type \"Mutation\"."
}
* {
"locations": [
{
"column": 2,
"line": 4
}
],
"message": "Field \"deleteCodeownersFiles\" argument \"repositoryIDs\" of type \"[Int!]!\" is required but not provided."
}
exit status 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you try it as of https://github.com/sourcegraph/sourcegraph/pull/48584?
leonore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on latest main!
Requires https://github.com/sourcegraph/sourcegraph/pull/48584.
Closes https://github.com/sourcegraph/sourcegraph/issues/47823.
Test plan
Verified with the new backend endpoints.