Skip to content

Conversation

@jhchabran
Copy link
Contributor

@jhchabran jhchabran commented Mar 2, 2023

Update to 1.19.6 because it fixes a bunch of CVEs.

Created by Sourcegraph batch change jhchabran/update-to-go-1.19.6.

It seems that we're targeting go 1.18.x, so I only added a small test for that branch but kept the rest with 1.18.x. Is that ok?

Test Plan: CI

@jhchabran jhchabran requested a review from keegancsmith March 8, 2023 15:52
@jhchabran jhchabran enabled auto-merge (squash) March 8, 2023 15:52
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we're targeting go 1.18.x, so I only added a small test for that branch but kept the rest with 1.18.x. Is that ok?

We aren't targetting it, we just hardcoded it before to ensure we ran on that version.

@jhchabran jhchabran merged commit 85115b1 into main Mar 8, 2023
@jhchabran jhchabran deleted the update-to-go-1.19.6 branch March 8, 2023 18:12
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* Update asdf to Go 1.19.6

* Also test against go 1.19.x

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants