Adds validation of CSI drivers for GKE #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonhawkharris
force-pushed
the
jhh/gke-validation
branch
from
44d846c to
c1f0bac
Compare
jasonhawkharris
force-pushed
the
jhh/gke-validation
branch
from
c1f0bac to
e4306a3
Compare
jdpleiness
approved these changes
Mar 2, 2023
Contributor
jdpleiness
left a comment
jdpleiness
left a comment
There was a problem hiding this comment.
LGTM, just a few cleanup items 🚀
jasonhawkharris
force-pushed
the
jhh/gke-validation
branch
from
498d4e6 to
149efb0
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* add validate support for gke * set up gke validation flow, add nil validator * checks if storageClass is configured for gce-pd volumes * Adds validation for gke persistent volume drivers * delete commented import and remove unneeded context from gke function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Manual testing. The functionality is, in itself, a test. Manually tested failing case and passing case.