Skip to content

Conversation

@erzhtor
Copy link
Contributor

@erzhtor erzhtor commented Apr 20, 2023

Part of https://github.com/sourcegraph/pr-faqs/issues/96. Related https://github.com/sourcegraph/sourcegraph/pull/50908.

Test plan

  • make sure that both versions work the same
$ go run ./cmd/src repos {add|update|delete}-kvp
$ go run ./cmd/src repos {add|update|delete}-metadata

Copy link

@limitedmage limitedmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@erzhtor erzhtor requested review from ryphil, tdmosk and toolmantim and removed request for tdmosk April 21, 2023 09:36
Copy link
Member

@camdencheek camdencheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@erzhtor erzhtor force-pushed the erzhtor/rename-kvp-to-metadata branch from 0e8b999 to 3ceaa85 Compare April 24, 2023 08:42
@erzhtor erzhtor merged commit ea9e501 into main Apr 24, 2023
@erzhtor erzhtor deleted the erzhtor/rename-kvp-to-metadata branch April 24, 2023 08:56
scjohns pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants