Skip to content

[CONSUL-519] Implement mkfifo Alternative#84

Merged
ezfepo merged 2 commits into
qa-consulfrom
consulwindows-go-consul-519-implement-mkfifo-alternative
Oct 19, 2022
Merged

[CONSUL-519] Implement mkfifo Alternative#84
ezfepo merged 2 commits into
qa-consulfrom
consulwindows-go-consul-519-implement-mkfifo-alternative

Conversation

@joselo85
Copy link
Copy Markdown

Description

  • Created connect/envoy/exec_windows.go
  • Updated Build directives in connect/envoy/exec_unsupported.go to exclude Windows OS.

exec_windows.go

The file instead of using named pipes (FIFO files) uses temp json file on windows. Envoy is then started using the os.StartProcess function.

@joselo85 joselo85 added enhancement New feature or request go code labels Oct 18, 2022
@joselo85 joselo85 requested a review from ezfepo October 18, 2022 20:34
@joselo85 joselo85 self-assigned this Oct 18, 2022
@ezfepo ezfepo changed the base branch from qa to qa-consul October 18, 2022 20:54
@ezfepo ezfepo force-pushed the consulwindows-go-consul-519-implement-mkfifo-alternative branch 2 times, most recently from e40c20a to cf13a6b Compare October 18, 2022 21:01
@ezfepo ezfepo force-pushed the consulwindows-go-consul-519-implement-mkfifo-alternative branch from cf13a6b to 160786b Compare October 19, 2022 12:47
@ezfepo ezfepo merged this pull request into qa-consul Oct 19, 2022
@ezfepo ezfepo deleted the consulwindows-go-consul-519-implement-mkfifo-alternative branch October 19, 2022 20:35
ezfepo pushed a commit that referenced this pull request Nov 2, 2022
ezfepo pushed a commit that referenced this pull request Nov 2, 2022
ezfepo pushed a commit that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants