Skip to content

EX-2549 Address upstream comments#28

Merged
egsgordeev merged 6 commits intomasterfrom
EX-2549_address_upstream_comments
Dec 10, 2020
Merged

EX-2549 Address upstream comments#28
egsgordeev merged 6 commits intomasterfrom
EX-2549_address_upstream_comments

Conversation

@egsgordeev
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Address the comments from the upstream PR

slimkrazy and others added 6 commits December 8, 2020 10:50
* Key name change from vmuid to vmcid

* Change the userId key name to vmconnectid

* Support new key in response payload + remain backward compatible.

Co-authored-by: slimkrazy <sam@slimkrazy.com>
* add tagid to banner request

* bump version

* update test case

* run tests

Co-authored-by: John Salis <johnsalis@beachfrontmedia.com>
* follow spec to parse fpd
* ad unit support stub
* adunit method
* ad unit etc
* typo
* fix test
* typo
* change to const
@egsgordeev
Copy link
Author

Relevant changes are only in sovrnBidAdapter.js and sovrnBidAdapter_spec.js

Copy link

@jrosendahl jrosendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@cpabst cpabst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


const BIDDER_CODE = 'jixie';
const EVENTS_URL = 'https://jxhbtrackers.azurewebsites.net/sync/evt?';
const EVENTS_URL = 'https://hbtra.jixie.io/sync/hb?';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this come from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream origin 🤷‍♂️

@egsgordeev egsgordeev merged commit bc94810 into master Dec 10, 2020
@egsgordeev egsgordeev deleted the EX-2549_address_upstream_comments branch December 10, 2020 21:08
dmitrybor pushed a commit that referenced this pull request Jun 23, 2025
…rameters (prebid#13122)

* V 0 29 (#31)

* AGT-403: Add adType parameter to payload in report

* AGT-403: Test for partner report, adType parameter

* AGT-403: Test refactoring

* AGT-403: Documentation updated

* IntentIq Analytics Module: adUnitCode or placemetId to report (#9)

* AGT-446: adUnitCode or placemetId to report

* AGT-446: Description of changes, example

* AGT-446: Fix documentation

* AGT-446: Changes after review

* Agt 409 full url in prebid modules (#8)

* add sync

* update full url

* set url param

* fix comment

* fix issue fix sync mode

* update url

* update full url

* add test

* move browser_blacklist (#10)

* add is optedOut (#11)

* update date in FPD after sync (#12)

* update sync logic for new user (#13)

* fix unit tests

* change version name

* IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17)

* AGT-453: Support sourceMetaData

* AGT-453: sourceMetaDataExternal

* AGT-453: Documentation

* AGT-453: Changes after review

* AGT-453: Fix doc

* Fix doc

* AGT-453: Fix test

* update test

* update endpoint (#16)

* update endpoint

* update test

* add tests

* update test

* fix conflict

* fix conflict

* add test for reportingServerAddress

* add test for reportingServerAddress

* AGT-498: support report method parameter (#22)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: reportMethod parameter description (#23)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: Documentation

* Agt 452 server call counters (#18)

* add counters

* add unit tests and fixes

* counters additions

* clear counters when a request is made

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* add siloEnabled feature (#19)

* add siloEnabled feature

* add siloEnabled feature to analytics adapter

* add unit tests for siloEnabled feature

* add siloenabled to docs

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit test issues

* AGT-455: Source parameter in requests (#28)

* AGT-508: Spd parameter (#29)

* AGT-508: Spd parameter

* AGT-508: Move appendSpd to utils

* AGT-499: Support partnerClientIdType and partnerClientId (#30)

* AGT-499: partnerClientId and partnerClientIdType in requests

* AGT-499: Clean comment

* AGT-499: Refactoring

* add groupchanged parameter (#25)

* add groupchanged parameter

* fix md file issue

* add groupChanged example in docs

* remove group from example

* add unit tests and fix groupChanged issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* Agt 501 support additional params (#24)

* additionalParams feature init

* additional params add features

* additionalparams fix analytics adapter

* add unit tests for additionalParams

* fix currentBrowser issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* fix linter error

---------

Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit tests (#32)

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* Agt 547 vr bug for module (#33)

* save progress

* fix calling server

* add "dbsaved" parameter

* add tests

* AGT-552: Additional query params (#34)

* AGT-552: Additional query params

* update documentation

---------

Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>

* Fix unit test for specific browser

* fix spelling

---------

Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com>
Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments