Skip to content

set creativeId to crid if present in response #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aprakash-sovrn merged 1 commit into from
Apr 18, 2018
Merged

set creativeId to crid if present in response #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/sovrnBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const spec = {
cpm: parseFloat(sovrnBid.price),
width: parseInt(sovrnBid.w),
height: parseInt(sovrnBid.h),
creativeId: sovrnBid.id,
creativeId: sovrnBid.crid || sovrnBid.id,
dealId: sovrnBid.dealid || null,
currency: 'USD',
netRevenue: true,
Expand Down
58 changes: 41 additions & 17 deletions test/spec/modules/sovrnBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,30 +106,54 @@ describe('sovrnBidAdapter', function() {
});

describe('interpretResponse', () => {
let response = {
body: {
'id': '37386aade21a71',
'seatbid': [{
'bid': [{
'id': 'a_403370_332fdb9b064040ddbec05891bd13ab28',
'impid': '263c448586f5a1',
'price': 0.45882675,
'nurl': '<!-- NURL -->',
'adm': '<!-- Creative -->',
'h': 90,
'w': 728
let response;
beforeEach(() => {
response = {
body: {
'id': '37386aade21a71',
'seatbid': [{
'bid': [{
'id': 'a_403370_332fdb9b064040ddbec05891bd13ab28',
'crid': 'creativelycreatedcreativecreative',
'impid': '263c448586f5a1',
'price': 0.45882675,
'nurl': '<!-- NURL -->',
'adm': '<!-- Creative -->',
'h': 90,
'w': 728
}]
}]
}]
}
};
}
};
});

it('should get the correct bid response', () => {
let expectedResponse = [{
'requestId': '263c448586f5a1',
'cpm': 0.45882675,
'width': 728,
'height': 90,
'creativeId': 'a_403370_332fdb9b064040ddbec05891bd13ab28',
'creativeId': 'creativelycreatedcreativecreative',
'dealId': null,
'currency': 'USD',
'netRevenue': true,
'mediaType': 'banner',
'ad': decodeURIComponent(`<!-- Creative --><img src=<!-- NURL -->>`),
'ttl': 60000
}];

let result = spec.interpretResponse(response);
expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0]));
});

it('crid should default to the bid id if not on the response', () => {
delete response.body.seatbid[0].bid[0].crid;
let expectedResponse = [{
'requestId': '263c448586f5a1',
'cpm': 0.45882675,
'width': 728,
'height': 90,
'creativeId': response.body.seatbid[0].bid[0].id,
'dealId': null,
'currency': 'USD',
'netRevenue': true,
Expand All @@ -150,7 +174,7 @@ describe('sovrnBidAdapter', function() {
'cpm': 0.45882675,
'width': 728,
'height': 90,
'creativeId': 'a_403370_332fdb9b064040ddbec05891bd13ab28',
'creativeId': 'creativelycreatedcreativecreative',
'dealId': 'baking',
'currency': 'USD',
'netRevenue': true,
Expand Down