Cleaning up XGBoosterInplacePredict#6
Merged
sriggin merged 6 commits into1.7.5-sovrn-upgradefrom May 9, 2023
Merged
Conversation
cmdc0de
approved these changes
May 4, 2023
cmdc0de
left a comment
cmdc0de
left a comment
There was a problem hiding this comment.
+1
C++ looks great, I don't have enough knowledge of XGBoost to know if these are the right functions to be calling. Do you plan to open the PR back to XGBoost?
Collaborator
Author
Yes, there is a ticket to PR this back up to source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.