Conversation
Squashed commits: [2aa500b] Try a different way of creating the proxy [c92d2df] try only one path [2f81ff3] dMatrix Handle null check and more statments [2e6df6f] exit on entering ifs [688fc73] More null checks [3e37688] change error logging [710dae5] missing semicolon [489c337] Put checks back in, change check in c_api [ad5972d] time to break the cpu predictor [7dfa3c0] No more check, do it live [abd64ff] dereference for logging [eb4cd9a] See if we can log what the type for proxy is [74c4376] maybe log something [a367ca2] uncomment for test, pass dMatrix through Booster.java [3e98f14] comment out for testing [66f0d8c] Changes to tests [737b293] some more changes to test [b3796b7] a dMatrix for testing [e995228] Convert long to handle [66ca8c3] c h e c k s t y l e [14f2243] Checkstyle failure [163bfca] missing comma [c869a14] First try at getting dMatrix logic into changes
Squashed commits: [99b8f1f] Remove pom change [7b80fef] Remove changes from cpu_predictor, fix rebase miss [a531053] Cleaning up XGBoosterInplacePredict Further de-newification More clean-up [de6e109] pom change git didn't pick up (+5 squashed commits) Squashed commits: [6182244] One missed pom [ab5bc5e] Update all the poms, even the unused ones [a96c3b9] More clean-up [aea9cd3] Further de-newification [1539100] Cleaning up XGBoosterInplacePredict [a81361d] increment our version (+15 squashed commits) Squashed commits: [c4d6d52] missed param [b343f89] Remove redundant line [5609102] Remove need to pass DMatrix [e31c53d] another missed logging message [f6a2508] comment out some logging [148e29e] undo static cast [6372805] More logging [a173763] change how proxy is cast in cpu predictor [5a08ff8] proxy to stuff [823c92f] Dense adapter changes [9a3214b] change some variables and things [d9dd5c4] uncomment stuff, more logging [7968bca] Set dense data [9e79c2e] Try some stuff with DMatrix [2b8cca6] Print result of p_m.get()
yoquinjo
force-pushed
the
test-branch
branch
2 times, most recently
from
07fa990 to
573cc1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.