Jvm inplace predict#9
Merged
yoquinjo merged 7 commits intosovrn:sovrn-inplace-predict-javafrom Aug 21, 2023
Merged
Conversation
Author
|
I haven't tested whether the JVM environment is thread-safe. The previous attempt with I'm not an expert in Java, the ideal case for prediction to return is to have an array/tensor with proper shape, which can be calculated from the C function. But since the Java land doesn't have a de-facto array implementation, a plain array is returned instead. I might not be able to finish the full PR, feel free to merge if you find it useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yoquinjo Could you please take a look? This is a draft of the changes needed to use the internal inplace predict function based on your existing patch.
PredictFromDensefunction to implement inplace prediction, which doesn't make a data copy.