Added compatibility to bundlers (closes #144 #152 #153)#154
Closed
tabarra wants to merge 1 commit intosoyuka:mainfrom
Closed
Added compatibility to bundlers (closes #144 #152 #153)#154tabarra wants to merge 1 commit intosoyuka:mainfrom
tabarra wants to merge 1 commit intosoyuka:mainfrom
Conversation
Contributor
tabarra
commented
Sep 15, 2022
tabarra
commented
| Q | A |
|---|---|
| Branch? | main |
| Bug fix? | yes |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #144 #152 #153 |
| License | MIT |
| Doc PR | not required |
Collaborator
|
Hi tabara@ thank you for the PR. I think the change should look like more like this (i.e. we need to introduce a |
Contributor
Author
|
@simonepri Maybe, but that's fine because node caches modules so it's only actually included once. |
Owner
soyuka
added a commit
that referenced
this pull request
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.