fix(retry): safely handle UInt64 overflow and standardize max interval#43
Merged
ns-vasilev merged 1 commit intomainfrom Dec 13, 2025
Merged
fix(retry): safely handle UInt64 overflow and standardize max interval#43ns-vasilev merged 1 commit intomainfrom
ns-vasilev merged 1 commit intomainfrom
Conversation
…l unit The exponential backoff calculation could lead to a fatal error due to Double to UInt64 conversion overflow when the number of retries was high. This commit address two issues: 1. Prevents `UInt64` overflow by checking against `UInt64.max` before casting the calculated delay value 2. Refactors `maxInterval` to accept `DispatchTimeInterval?` instead of `UInt64?` to standardize the API and simplify usage for consumers
Generated by 🚫 Danger |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 99.09% 99.40% +0.31%
==========================================
Files 10 10
Lines 331 502 +171
==========================================
+ Hits 328 499 +171
Misses 3 3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.