Fix: roll back conversation history after LLM hard errors#104
Merged
jamiepine merged 1 commit intospacedriveapp:voicefrom Feb 21, 2026
Merged
Fix: roll back conversation history after LLM hard errors#104jamiepine merged 1 commit intospacedriveapp:voicefrom
jamiepine merged 1 commit intospacedriveapp:voicefrom
Conversation
This was referenced Feb 21, 2026
Collaborator
Author
|
Closes #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
CompletionError,ToolError, orToolServerErroroccurs during an agent turn, Rig has already mutated the historyVecin-place (appending a tool-call message) before returning the error. The caller was writing that mutated history back unconditionally, leaving a dangling tool-call entry with no corresponding result.On the next user turn the provider rejects the entire history with "tool call result does not follow tool call", making the channel permanently unresponsive until restarted.
The fix snapshots the history length before each agent call and truncates back to that point on hard errors.
MaxTurnsErrorandPromptCancelledare unaffected — Rig carries a valid updated history in those variants, so they continue to be written back normally.Found while testing local Whisper STT on top of #98. Claude and MiniMax were both failing with provider errors during initial model loading, which triggered the bug on every subsequent voice message.