Skip to content

wayland: dot is a build dependency#39854

Merged
michaelkuhn merged 2 commits intospack:developfrom
aumuell:wayland-dot
Oct 13, 2023
Merged

wayland: dot is a build dependency#39854
michaelkuhn merged 2 commits intospack:developfrom
aumuell:wayland-dot

Conversation

@aumuell
Copy link
Copy Markdown
Contributor

@aumuell aumuell commented Sep 7, 2023

without dot from graphviz this build failure happens:
../spack-src/doc/meson.build:5:6: ERROR: Program 'dot' not found or not executable

otherwise this build failure happens:
../spack-src/doc/meson.build:5:6: ERROR: Program 'dot' not found or not executable
@wdconinc
Copy link
Copy Markdown
Contributor

wdconinc commented Sep 7, 2023

Is this a dependency for all versions? Does this get used for docs and can we disable that?

renders several dependencies optional
@aumuell
Copy link
Copy Markdown
Contributor Author

aumuell commented Sep 7, 2023

Is this a dependency for all versions? Does this get used for docs and can we disable that?

dot and several other dependencies are for building docs only. I made docs optional and could disable a few other dependencies as well.

Copy link
Copy Markdown
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I can confirm this installs fine with and without the +doc variant.

Copy link
Copy Markdown
Member

@michaelkuhn michaelkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelkuhn michaelkuhn merged commit a3a2900 into spack:develop Oct 13, 2023
@aumuell aumuell deleted the wayland-dot branch October 13, 2023 20:04
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Oct 23, 2023
* wayland: dot is a build dependency

otherwise this build failure happens:
../spack-src/doc/meson.build:5:6: ERROR: Program 'dot' not found or not executable

* wayland: make building of documentation optional

renders several dependencies optional
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2023
* wayland: dot is a build dependency

otherwise this build failure happens:
../spack-src/doc/meson.build:5:6: ERROR: Program 'dot' not found or not executable

* wayland: make building of documentation optional

renders several dependencies optional
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
* wayland: dot is a build dependency

otherwise this build failure happens:
../spack-src/doc/meson.build:5:6: ERROR: Program 'dot' not found or not executable

* wayland: make building of documentation optional

renders several dependencies optional
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
* wayland: dot is a build dependency

otherwise this build failure happens:
../spack-src/doc/meson.build:5:6: ERROR: Program 'dot' not found or not executable

* wayland: make building of documentation optional

renders several dependencies optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants