Skip to content

spectre: add v2023.10.11#40463

Merged
alalazo merged 2 commits intospack:developfrom
sxs-bot:spectre-v2023.10.11
Oct 30, 2023
Merged

spectre: add v2023.10.11#40463
alalazo merged 2 commits intospack:developfrom
sxs-bot:spectre-v2023.10.11

Conversation

@sxs-bot
Copy link
Copy Markdown
Contributor

@sxs-bot sxs-bot commented Oct 11, 2023

No description provided.

@alecbcs
Copy link
Copy Markdown
Member

alecbcs commented Oct 11, 2023

@nilsvu looks like the file needs to be reformatted with black to fix the style check.

@nilsvu
Copy link
Copy Markdown
Contributor

nilsvu commented Oct 12, 2023

Isn't there a bot automation to fix the style? I did run spack style --fix PATH_TO_FILE, which used to work but now fails like this on GitHub Actions:

==> Error: Command exited with status 2:
==> [BOOTSTRAPPING] Spack has missing dependencies, creating a bootstrapping environment
==> [BOOTSTRAPPING] Installing dependencies (py-isort@4.3.5:, py-mypy@0.900:, py-black@:23.1.0, py-flake8@3.8.2:, py-pytest@6.2.4:)
'/usr/bin/make' '-C' '/home/runner/.spack/bootstrap/environments/python3.10-x86_64-7d8fd' '-j' '2'

@alecbcs
Copy link
Copy Markdown
Member

alecbcs commented Oct 12, 2023

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Oct 12, 2023

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Oct 12, 2023

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/spectre/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/spectre/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 588 source files
  mypy checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@alalazo alalazo merged commit c2f3943 into spack:develop Oct 30, 2023
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2023
Co-authored-by: nilsvu <nilsvu@users.noreply.github.com>
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
Co-authored-by: nilsvu <nilsvu@users.noreply.github.com>
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
Co-authored-by: nilsvu <nilsvu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants