Skip to content

dataTransferKit: add v3.1.1, v3.1.0#40556

Merged
alecbcs merged 2 commits intospack:developfrom
masterleinad:update_datatransferkit_3_1_1
Oct 26, 2023
Merged

dataTransferKit: add v3.1.1, v3.1.0#40556
alecbcs merged 2 commits intospack:developfrom
masterleinad:update_datatransferkit_3_1_1

Conversation

@masterleinad
Copy link
Copy Markdown
Contributor

No description provided.

@alecbcs alecbcs changed the title Update DataTransferKit for 3.1.1 release dataTransferKit: add v3.1.1, v3.1.0 Oct 16, 2023
Comment on lines 24 to 25
version("3.1-rc3", commit="691d5a1540f7cd42141a3b3d2a7c8370cbc3560a", submodules=True)
version("3.1-rc2", commit="1abc1a43b33dffc7a16d7497b4185d09d865e36a", submodules=True)
Copy link
Copy Markdown
Member

@alecbcs alecbcs Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rombur @masterleinad do we want to deprecate these release candidates now that stable versions are available?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary. If I understood the doc correctly, deprecating packages should be used for insecure packages which is not the case here.

Copy link
Copy Markdown
Member

@alecbcs alecbcs Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insecure versions are the most common reason for deprecating a package. However we commonly deprecate/remove release candidates since they're versions that are unlikely to be used/wanted by end users.

If you think someone will want to use the DataTransferKit release candidates I'm happy to keep them in, but otherwise they'll likely just add to increased concretization times.

@alecbcs alecbcs self-assigned this Oct 16, 2023
@alecbcs
Copy link
Copy Markdown
Member

alecbcs commented Oct 16, 2023

It looks like the errors in Spack CI are legitimate failures in the build of DataTransferKit.

@eugeneswalker
Copy link
Copy Markdown
Contributor

All CI is green, should we merge?

@alecbcs
Copy link
Copy Markdown
Member

alecbcs commented Oct 25, 2023

Unless anyone has suggestions for why they should be kept in, I'd kinda like to deprecate the release candidates before merging.

@masterleinad
Copy link
Copy Markdown
Contributor Author

Unless anyone has suggestions for why they should be kept in, I'd kinda like to deprecate the release candidates before merging.

Specific xSDK versions require these release candidates.

Copy link
Copy Markdown
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed commits. @masterleinad thanks for the new versions!

@alecbcs alecbcs merged commit d64f312 into spack:develop Oct 26, 2023
victoria-cherkas pushed a commit to victoria-cherkas/spack that referenced this pull request Oct 30, 2023
* Update DataTransferKit for 3.1.1 release

* Require Trilinos-14 for 3.1.0 and higher
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2023
* Update DataTransferKit for 3.1.1 release

* Require Trilinos-14 for 3.1.0 and higher
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
* Update DataTransferKit for 3.1.1 release

* Require Trilinos-14 for 3.1.0 and higher
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
* Update DataTransferKit for 3.1.1 release

* Require Trilinos-14 for 3.1.0 and higher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants