dataTransferKit: add v3.1.1, v3.1.0#40556
Conversation
| version("3.1-rc3", commit="691d5a1540f7cd42141a3b3d2a7c8370cbc3560a", submodules=True) | ||
| version("3.1-rc2", commit="1abc1a43b33dffc7a16d7497b4185d09d865e36a", submodules=True) |
There was a problem hiding this comment.
@Rombur @masterleinad do we want to deprecate these release candidates now that stable versions are available?
There was a problem hiding this comment.
I don't think that's necessary. If I understood the doc correctly, deprecating packages should be used for insecure packages which is not the case here.
There was a problem hiding this comment.
Insecure versions are the most common reason for deprecating a package. However we commonly deprecate/remove release candidates since they're versions that are unlikely to be used/wanted by end users.
If you think someone will want to use the DataTransferKit release candidates I'm happy to keep them in, but otherwise they'll likely just add to increased concretization times.
|
It looks like the errors in Spack CI are legitimate failures in the build of DataTransferKit. |
|
All CI is green, should we merge? |
|
Unless anyone has suggestions for why they should be kept in, I'd kinda like to deprecate the release candidates before merging. |
Specific |
alecbcs
left a comment
There was a problem hiding this comment.
Confirmed commits. @masterleinad thanks for the new versions!
* Update DataTransferKit for 3.1.1 release * Require Trilinos-14 for 3.1.0 and higher
* Update DataTransferKit for 3.1.1 release * Require Trilinos-14 for 3.1.0 and higher
* Update DataTransferKit for 3.1.1 release * Require Trilinos-14 for 3.1.0 and higher
* Update DataTransferKit for 3.1.1 release * Require Trilinos-14 for 3.1.0 and higher
No description provided.