Docs: Update spec variant checks plus a few extra changes and "bug" fixes#40643
Merged
haampie merged 1 commit intospack:developfrom Oct 23, 2023
Merged
Docs: Update spec variant checks plus a few extra changes and "bug" fixes#40643haampie merged 1 commit intospack:developfrom
haampie merged 1 commit intospack:developfrom
Conversation
spackbot-app
Bot
added
conflicts
core
haampie
approved these changes
Oct 23, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Oct 23, 2023
victoria-cherkas
pushed a commit
to victoria-cherkas/spack
that referenced
this pull request
Oct 30, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Nov 2, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is pretty common that I suggest switching from
"+variant" in spectospec.satisfies("+variant")so changed all occurrences and like to paste links to the docs so it would be nice if the docs reflect the switch.While I was changing the files, I switched each file's examples to use f-strings and black's double quotes.
Also fixed a code-block example to python; added an example of using a helper method as an alternative to the current example (with a link to the helper's documentation); and an ending paragraph to a note.