Skip to content

pythia8: fix configure args#40644

Merged
tldahlgren merged 1 commit intospack:developfrom
jmcarcell:pythia8
Nov 6, 2023
Merged

pythia8: fix configure args#40644
tldahlgren merged 1 commit intospack:developfrom
jmcarcell:pythia8

Conversation

@jmcarcell
Copy link
Copy Markdown
Contributor

Adding a string to a list in python with += adds each character as one element of the list instead of adding the whole string as a single element so the configure args look like this:

--with-hepmc2=/cvmfs/sw-nightlies.hsf.org/key4hep/releases/2023-10-06-paestum/x86_64-ubuntu22.04-g
cc11.3.0-opt/hepmc/2.06.11-3hwln5 - - w i t h o u t - m g 5 m e s --without-hepmc3 - - w i t h o u
 t - f a s t j e t 3 --without-evtgen --without-root --without-rivet --without-python --without-op
enmp --without-mpich --without-hdf5

Copy link
Copy Markdown
Member

@ChristianTackeGSI ChristianTackeGSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an idea, could you look into it?

If this does not work, I am happily approving this, because this is obviously wrong the current way.

Comment thread var/spack/repos/builtin/packages/pythia8/package.py
@tldahlgren
Copy link
Copy Markdown
Contributor

@jmcarcell ping me when you're ready for this PR to be merged.

@jmcarcell
Copy link
Copy Markdown
Contributor Author

@tldahlgren It's ready for merging

@tldahlgren tldahlgren merged commit c6c689b into spack:develop Nov 6, 2023
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants