Merged
Conversation
Member
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
I have an idea, could you look into it?
If this does not work, I am happily approving this, because this is obviously wrong the current way.
Contributor
|
@jmcarcell ping me when you're ready for this PR to be merged. |
Contributor
Author
|
@tldahlgren It's ready for merging |
tldahlgren
approved these changes
Nov 6, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a string to a list in python with
+=adds each character as one element of the list instead of adding the whole string as a single element so the configure args look like this: