Merged
Conversation
Member
|
Any reason for actually dropping the patches? In case someone wants to build 2.1.3 for archaeological reasons, it will fail, right? |
Member
Author
|
Hm, I don't really see the point of having 2.1.3 + a thousand lines of patches, if it is more or less identical to 2.1.4. |
haampie
force-pushed
the
bump/zlib-ng-2
branch
from
c1bf63d to
5ffa626
Compare
Member
Author
|
Ok, I'll do it properly: keep the patches, deprecated the older patch releases, remove them + patches after Spack 0.21 release. |
haampie
changed the title
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Oct 23, 2023
victoria-cherkas
pushed a commit
to victoria-cherkas/spack
that referenced
this pull request
Oct 30, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Nov 2, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's drop the many patches in the next spack release