PyTorch: patch breakpad dependency#40648
Merged
manuelakuhn merged 1 commit intospack:developfrom Oct 25, 2023
Merged
Conversation
adamjstewart
commented
Oct 21, 2023
| default=True, | ||
| description="Enable breakpad crash dump library", | ||
| when="@1.9:1.11", | ||
| when="@1.10:1.11", |
Member
Author
There was a problem hiding this comment.
Seems like 1.9 can build with external breakpad, but 1.10–1.11 can only build with third party breakpad. And 1.9 has no way of controlling whether or not breakpad gets built. I think it's safer to ignore it on 1.9.
Contributor
|
yep. it fixes the issue. Thanks. Please merge. |
manuelakuhn
approved these changes
Oct 25, 2023
Member
manuelakuhn
left a comment
manuelakuhn
left a comment
There was a problem hiding this comment.
I could reproduce the error and can confirm that this fixes it.
victoria-cherkas
pushed a commit
to victoria-cherkas/spack
that referenced
this pull request
Oct 30, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Nov 2, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 11, 2024
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Sinan81 can you see if this fixes #40629?