Seacas: Update for latest seacas releaes version#40698
Merged
sethrj merged 6 commits intospack:developfrom Oct 31, 2023
Merged
Conversation
Add option to pull latest SEACAS release; update dependency version information.
Sorry for churn; need to get my eyes checked since I can't seem to see misaligned braces...
sethrj
reviewed
Oct 31, 2023
Comment on lines
+138
to
+139
| depends_on("cmake@3.17:", type="build") | ||
| depends_on("cmake@3.22:", when="@2023-10-24", type="build") |
Contributor
There was a problem hiding this comment.
Suggested change
| depends_on("cmake@3.17:", type="build") | |
| depends_on("cmake@3.22:", when="@2023-10-24", type="build") | |
| depends_on("cmake@3.22:", when="@2023-10-24:", type="build") | |
| depends_on("cmake@3.17:", when="@:2023-05-30", type="build") |
These should probably be ranges, and dependencies are usually ordered so newer versions are before older ones.
Contributor
Author
There was a problem hiding this comment.
done i think. Is master considered after 2023-10-24?
Comment on lines
+148
to
+150
| depends_on("fmt@9.1.0", when="@2022-10-14") | ||
| depends_on("fmt@9.1.0:", when="@2023-05-30") | ||
| depends_on("fmt@10.1.0:", when="@2023-10-24") |
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Nov 2, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to pull latest SEACAS release; update dependency version information.