fdb: add dependency on eckit later release#40737
Merged
alecbcs merged 5 commits intospack:developfrom Nov 10, 2023
Merged
Conversation
alecbcs
changed the title
alecbcs
requested changes
Oct 28, 2023
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
@victoria-cherkas thanks for the fix! This PR is looking great, just a quick formatting suggestion and then we're good to merge.
Co-authored-by: Alec Scott <alec@bcs.sh>
Contributor
Author
|
@alecbcs committed your suggestion - thanks for the review! |
Contributor
Author
|
@alecbcs I also just added a commit to make the latest tagged commit the default install, since the master branch dependencies can change and arent defined by spack. |
Contributor
Author
|
Any chance this can get a re-review @alecbcs and @skosukhin ? |
Member
|
Commit f258f46 makes no difference functionality-wise and violates the convention (most recent versions should be on the top). |
Contributor
Author
|
@skosukhin thanks for the feedback, reverted the ordering. |
alecbcs
approved these changes
Nov 10, 2023
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
Changes look good to me. @victoria-cherkas thanks for the fix!
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
* depends_on("eckit@1.24.4:", when="@5.11.22:")
* Update var/spack/repos/builtin/packages/fdb/package.py
Co-authored-by: Alec Scott <alec@bcs.sh>
* make latest tagged release the default install
* revert spack@f258f46
---------
Co-authored-by: Alec Scott <alec@bcs.sh>
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
* depends_on("eckit@1.24.4:", when="@5.11.22:")
* Update var/spack/repos/builtin/packages/fdb/package.py
Co-authored-by: Alec Scott <alec@bcs.sh>
* make latest tagged release the default install
* revert spack@f258f46
---------
Co-authored-by: Alec Scott <alec@bcs.sh>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
* depends_on("eckit@1.24.4:", when="@5.11.22:")
* Update var/spack/repos/builtin/packages/fdb/package.py
Co-authored-by: Alec Scott <alec@bcs.sh>
* make latest tagged release the default install
* revert spack@f258f46
---------
Co-authored-by: Alec Scott <alec@bcs.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds dependency on eckit@1.24.4: when fdb@5.11.22:
fdb CMakeLists.txt changed from:
ecbuild_find_package( NAME eckit VERSION 1.12 REQUIRED )to:
ecbuild_find_package( NAME eckit VERSION 1.24.4 REQUIRED )in v5.11.22 see ecmwf/fdb@5.11.21...5.11.22