Skip to content

superlu-dist: add +parmetis variant.#40746

Merged
eugeneswalker merged 2 commits intospack:developfrom
jacobrking:jking-superlu-dist-optional-parmetis
Nov 7, 2023
Merged

superlu-dist: add +parmetis variant.#40746
eugeneswalker merged 2 commits intospack:developfrom
jacobrking:jking-superlu-dist-optional-parmetis

Conversation

@jacobrking
Copy link
Copy Markdown
Contributor

Expose ability to make parmetis an optional superlu-dist dependency to spack package management.

Parmetis as a dependency is enabled by default.

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Oct 27, 2023

@gchavez2 @xiaoye can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • superlu-dist

@jacobrking jacobrking force-pushed the jking-superlu-dist-optional-parmetis branch 2 times, most recently from c899b0c to f3f89d8 Compare October 27, 2023 17:39
@jacobrking jacobrking marked this pull request as ready for review October 27, 2023 17:44
eugeneswalker
eugeneswalker previously approved these changes Oct 27, 2023
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor request to update the variant description

Comment thread var/spack/repos/builtin/packages/superlu-dist/package.py Outdated
@alalazo alalazo enabled auto-merge (squash) November 1, 2023 19:47
@eugeneswalker
Copy link
Copy Markdown
Contributor

@spackbot run pipeline - previous jobs were failing because of read timeouts, seem spurious, perhaps we'll have better luck this time

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Nov 2, 2023

I've started that pipeline for you!

@eugeneswalker
Copy link
Copy Markdown
Contributor

@spackbot run pipeline down to one job failing because of a read timeout, the other previously failing jobs succeeded on retry

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Nov 2, 2023

I've started that pipeline for you!

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Nov 2, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Nov 2, 2023

I've started that pipeline for you!

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Nov 2, 2023

Apparently we are always getting the same fetch error here

@eugeneswalker
Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Nov 2, 2023

I've started that pipeline for you!

auto-merge was automatically disabled November 6, 2023 14:35

Head branch was pushed to by a user without write access

@jacobrking jacobrking force-pushed the jking-superlu-dist-optional-parmetis branch from 8951e7e to 18ff3fe Compare November 6, 2023 14:35
@eugeneswalker
Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented Nov 7, 2023

I've started that pipeline for you!

@eugeneswalker
Copy link
Copy Markdown
Contributor

All CI is green, should we wait for more review or is this ready to merge?

@jacobrking
Copy link
Copy Markdown
Contributor Author

@liuyangzhuan Do you think we need more approvals? I just left the auto-populated reviewers when I made the PR. From my perspective this is ready to go.

@liuyangzhuan
Copy link
Copy Markdown
Contributor

@liuyangzhuan Do you think we need more approvals? I just left the auto-populated reviewers when I made the PR. From my perspective this is ready to go.
@jacobrking @eugeneswalker I think this is good to go. No more reviews is really needed.

@eugeneswalker eugeneswalker merged commit a093f4a into spack:develop Nov 7, 2023
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
* Expose ability to make parmetis an optional superlu-dist dependency to
spack package management.

* rename parmetis variant: Enable ParMETIS library

---------

Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com>
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
* Expose ability to make parmetis an optional superlu-dist dependency to
spack package management.

* rename parmetis variant: Enable ParMETIS library

---------

Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants