sundials +sycl: add cxxflags=-fsycl via flag_handler#40845
Merged
eugeneswalker merged 3 commits intospack:developfrom Nov 4, 2023
Merged
sundials +sycl: add cxxflags=-fsycl via flag_handler#40845eugeneswalker merged 3 commits intospack:developfrom
eugeneswalker merged 3 commits intospack:developfrom
Conversation
spackbot-app
Bot
requested review from
balay,
balos1,
gardner48,
osborn9 and
ulrikeyang
eugeneswalker
force-pushed
the
sundials-sycl-cxxflags-fsycl
branch
from
5ce0c6e to
c744621
Compare
balos1
previously approved these changes
Nov 2, 2023
gardner48
previously approved these changes
Nov 2, 2023
wspear
previously approved these changes
Nov 2, 2023
eugeneswalker
dismissed stale reviews from wspear, gardner48, and balos1
via
6d86a82
spackbot-app
Bot
added
core
wspear
previously approved these changes
Nov 2, 2023
balay
previously approved these changes
Nov 3, 2023
Contributor
balay
left a comment
balay
left a comment
There was a problem hiding this comment.
Builds with xsdk+sycl (on sundials develop branch) via:
+ xsdk_depends_on("sundials +sycl cxxstd=17", when="@1.0.0: +sycl")
Contributor
@eugeneswalker, perhaps this branch needs a rebase. |
eugeneswalker
force-pushed
the
sundials-sycl-cxxflags-fsycl
branch
from
6d86a82 to
b6b2fee
Compare
wspear
previously approved these changes
Nov 3, 2023
balay
approved these changes
Nov 4, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40807
@balos1 @cswoodward @gardner48