Conversation
|
Hi @wdconinc! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("wdconinc")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame qwtThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
Contributor
Author
|
Seems to have done the job, https://gitlab.spack.io/spack/spack/-/jobs/8975520 |
wdconinc
requested review from
ajaust and
alalazo
and removed request for
ajaust
Contributor
Author
|
(sorry ajaust in case you got a notification: my dog stepped on my phone and assigned you as a reviewer by mistake) |
Contributor
Author
|
Fails in visit now, https://gitlab.spack.io/spack/spack/-/jobs/8975696, logs well hidden due to cutoff. At least the CI build should be fixed by #40882, maybe. |
Contributor
Author
|
Build issue in visit already reported at #40731. |
wdconinc
force-pushed
the
qwt-conflict-qt-base
branch
from
bda3ec1 to
6b1baa3
Compare
Contributor
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
wdconinc
commented
Nov 8, 2023
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
alalazo
approved these changes
Nov 13, 2023
4 tasks
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
Member
|
FYI: For VisIt 3.4, we are building Qt6 + Qwt. We have a few patches that we use for qwt in build_visit that maybe could be used in spack: https://github.com/visit-dav/visit/blob/develop/src/tools/dev/scripts/bv_support/bv_qwt.sh |
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #40882.
Qwt does not support Qt6 yet, but pulls in qmake default provider qt-base in e.g. https://gitlab.spack.io/spack/spack/-/jobs/8960286 leading to failing builds in e.g. https://gitlab.spack.io/spack/spack/-/jobs/8961356