Installer: queue only link/run deps unless building from source#46101
Closed
Installer: queue only link/run deps unless building from source#46101
Conversation
spackbot-app
Bot
added
binary-packages
commands
core
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
2 times, most recently
from
e7980d2 to
fbc7ad9
Compare
tldahlgren
force-pushed
the
features/install-binary-no-build-deps
branch
from
d6d8dbb to
085cff4
Compare
tldahlgren
reviewed
Sep 5, 2024
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
I'm still reviewing this but wanted to add the comment.
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
2 times, most recently
from
52ec48e to
63c8bd6
Compare
tldahlgren
reviewed
Sep 5, 2024
| "The spec is now uninstalled." | ||
| ) | ||
|
|
||
| # Unwrap the actuall installation exception |
Contributor
There was a problem hiding this comment.
Typo: actuall -> actual.
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
3 times, most recently
from
5e8476b to
c0e596c
Compare
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
from
c0e596c to
e8327bc
Compare
4 tasks
tldahlgren
force-pushed
the
features/install-binary-no-build-deps
branch
from
7261682 to
58ed9be
Compare
4 tasks
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
from
58ed9be to
d87158a
Compare
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
from
d87158a to
ac86eb2
Compare
…eded Refactors BuildTask into separate classes BuildTask and InstallTask Queues all packages as InstallTask, with link/run deps only If an InstallTask fails to install from binary, a BuildTask is generated The BuildTask is queued with dependencies on the new InstallTasks for its build deps and their link/run dependencies. The Tasks telescope open to include all build deps of build deps ad-hoc
- test/installer: use existing inst for spack.installer
- remove install status from Installing message
- Add specs count visitor
- Report status on installed plus minor refactor
- Add the "+" to the tracker; include one experimental dynamic calculation
- tweak status reporting to include ensuring numerator unique across installed packages
- _print_installed_pkg -> InstallStatus.print_installed()
- move set_term_title outside of InstallStatus
- InstallStatus: remove unnecessary next_pkg
- InstallStatus: class and method name changes
* changed InstallStatus to InstallerStatus since already have former in
database.py and spec.py
* changed print_installed to set_installed since does more than print now
- InstallerStatus -> InstallerProgress, install_status -> progress
- InstallerProgress: cache config:install_status
- InstallerProgress: restore get_progress and set_term_title methods (w/ tweaks)
- Task execute(): added returns to docstrings
- Don't pass progress to build_process or Installer.run, but set installed on successful return
- fix mypy issue with pkg.run_tests assignment
Signed-off-by: Gregory Becker <becker33@llnl.gov>
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
from
ac86eb2 to
7d48c18
Compare
bcumming
added a commit
to eth-cscs/stackinator
that referenced
this pull request
Jul 9, 2025
Remove the bootstrap compiler stage. - remove the `compilers/bootstrap` environment - the first target is the `compilers/gcc` environment - remove external packages from `compilers/gcc` - these can cause difficulties for users the environment as a downstream package - the build dependencies will not be included in the target uenv when spack/spack#46101 is merged - create a special `uenv_tools` environment that builds the `squashfs` package (which was built in `bootstrap`) - update tests Bonus extra: - fix the build cache access token warning Fixes #241 Fixes #239 --------- Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Contributor
|
This pull request has been automatically marked as stale because it has not had any activity in the last 6 months. It will be closed in 30 days if there is no further activity. If the pull request is waiting for a reply from reviewers, feel free to ping them as a reminder. If it is waiting and has no assigned reviewer, feel free to ping To get more eyes on your pull request, you can post a link in the #pull-requests channel of the Spack Slack. |
Contributor
|
This pull request was closed because it had no activity for 30 days after being marked stale. If you feel this is in error, please feel free to reopen this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #39136 (commits up-to/including 39ff are from that PR)
TODO: