Use of logical '&&' with constant operand

[rubienr]

Multiple usages of logical && with constant operand for example imuMeas.dataType[i] = (bitField && 0xFF000000) >> 23 in:

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 3597 in 97bd455

imuMeas.xAngRateVald = (validity && 0x0080) >> 8;

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 3632 in 97bd455

uint8_t timeSent = (flags && 0x01) >> 1;

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 3646 in 97bd455

imuMeas.dataType[i] = (bitField && 0xFF000000) >> 23;

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 3670 in 97bd455

imuMeas.rawDataType = (bitField && 0xFF000000) >> 23;

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 3706 in 97bd455

ubloxSen.senType = (sensorFieldOne && 0x10) >> 5;

[PaulZC]

Many thanks @rubienr for spotting this! Yes, they should be bitwise ANDs (&).
@edspark - just copying you in so you are aware. I'll change this in the release_candidate branch ready for the next release.
Thanks again,
Paul

[PaulZC]

Hi @rubienr & @edspark ,
@rubienr : thank you again for spotting this!
I have corrected the ANDs (and some of the bit masks) in this commit.
@edspark : can you please review the changes - and test if possible? I don't have a dead-reckoning module here to test them on... :-( Thanks!
Best wishes,
Paul

[rubienr]

Hi,

I am at a very early stage with my project development and my prototype is stationary for the moment. Thus I cannot meningfully test dead-reckoning. However I switched my dependency to the RC branch. Will keep you posted if I find issues related to this commit.

I tried to compile with -Wall -Werror and for this the unused variables would need to be uncommented (sorry for being off topic in this thread):

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 3849 in aac251e

uint16_t refStationID = extractInt(2);

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 4004 in aac251e

uint32_t timeStamp = extractLong(0);

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 4007 in aac251e

uint8_t timeSent = flags & 0x03; // timeSent is 2-bit: 0 = none, 1 = on Ext0, 2 = on Ext1

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 4008 in aac251e

uint8_t timeEdge = (flags & 0x04) >> 2;

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp

Line 4009 in aac251e

uint8_t tagValid = (flags & 0x08) >> 3;