optimize arguments and type checking, fix JSDoc#1
Open
zhibirc wants to merge 1 commit intospasdk:masterfrom
Open
optimize arguments and type checking, fix JSDoc#1zhibirc wants to merge 1 commit intospasdk:masterfrom
zhibirc wants to merge 1 commit intospasdk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base version had a few problems with handling falsy values such as
0, small overhead and didn't consider Text Nodes (because they implement Node interface, not Element). Also added some corrections to JSDoc style, fix examples fordom.addand correct inline comments.