Skip to content

Conversation

@JPEWdev
Copy link
Collaborator

@JPEWdev JPEWdev commented Jan 10, 2025

This is the initial implementation of the SPDX Python bindings

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggest and a question.

Otherwise, LGTM.

Thanks @JPEWdev

README.md Outdated
```python
import spdx_python_model

p = spdx_python_model.v3_0_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p = spdx_python_model.v3_0_1
m = spdx_python_model.v3_0_1

Suggest using a different variable from the person since they represent different objects

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually just a typo. I'll fix it.

This is the initial implementation of the SPDX Python bindings
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JPEWdev JPEWdev merged commit aa40861 into spdx:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants