gha: Enable publishing to PyPi #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bact
reviewed
Mar 6, 2025
bact
approved these changes
Mar 6, 2025
Collaborator
|
Ahh. I think there's a bug in GitHub web interface. You can't have the last line of the suggestion to be the ending fence "```". You better edit this in your own text editor. I'm sorry @JPEWdev |
Collaborator
|
Line 19 supposed to have the closing "```" :( |
Collaborator
Author
|
Weird |
goneall
approved these changes
Mar 6, 2025
Member
goneall
left a comment
goneall
left a comment
There was a problem hiding this comment.
I may not be the best reviewer for Python publishing, but the changes look good to me.
Member
|
@maxhbr - would you mind giving this a quick review |
There are projects wanting to use the Python bindings, and pulling them from github is annoying, particularly because it's not allowed to publish a downstream package that contains these bindings if they are pulled from GitHub. As such, enable publishing to PyPi Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are projects wanting to use the Python bindings, and pulling them from github is annoying, particularly because it's not allowed to publish a downstream package that contains these bindings if they are pulled from GitHub.
As such, enable publishing to PyPi