Escape quotes in locality name for GEOLocate integration#7927
Open
foozleface wants to merge 1 commit intospecify:mainfrom
Open
Escape quotes in locality name for GEOLocate integration#7927foozleface wants to merge 1 commit intospecify:mainfrom
foozleface wants to merge 1 commit intospecify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7664
Contributed by @foozleface
Locality names containing single or double quotes break the GEOLocate plugin because its internal page scripts cannot handle embedded quote characters in URL parameters, causing the map to fail to render.
Implementation
sanitizeGeoLocateData()helper that strips"and'characters from all data values before they are passed to the GEOLocate URL builderGenericGeoLocatewhen constructing the URL, replacing the direct...dataspread with...sanitizeGeoLocateData(data)pointsparameterTesting instructions
Near "Big Rock" CreekorO'Brien's Landing)