Add .iterator() to unbounded querysets#7940
Open
foozleface wants to merge 1 commit intospecify:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7864
Contributed by @foozleface
Approximately 80 callsites in the backend use
.all()without.iterator(), causing Django to cache all results in the QuerySet internal result cache. For large tables this means loading entire result sets into memory at once. This PR adds.iterator(chunk_size=2000)to 9 high-impact paths where unbounded querysets are iterated.Implementation
.iterator(chunk_size=2000)to COG prep consolidation queries incog_preps.py(2 callsites).iterator(chunk_size=2000)to role policy serialization inpermissions/views.py.iterator(chunk_size=2000)to deaccession total calculation incalculated_fields.py.iterator(chunk_size=2000)to dependent to-many serialization inapi/serializers.py.iterator(chunk_size=2000)to tree definition rank loading intrees/views.pycreatedbyagentvalues inupload_table.py.iterator()is called on the target querysetsTesting instructions
python manage.py test specifyweb.specify.tests.test_queryset_iterators