Remove old serialize-javascript version dependency#7944
Open
acwhite211 wants to merge 1 commit intomainfrom
Open
Remove old serialize-javascript version dependency#7944acwhite211 wants to merge 1 commit intomainfrom
acwhite211 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7933
Fixes https://github.com/specify/specify7/security/dependabot/186
Dependabot flagged serialize-javascript <= 7.0.2 as vulnerable to RCE. This issue was introduced transitively through terser-webpack-plugin@5.3.11 in the front-end dependency tree. We can use terser-webpack-plugin@5.4.0 since it no longer depends on serialize-javascript, so this change removes the vulnerable package entirely rather than pinning serialize-javascript directly.
Removed vulnerable serialize-javascript from front-end lockfile. Added an override for terser-webpack-plugin in specifyweb/frontend/js_src/package.json. Update specifyweb/frontend/js_src/package-lock.json to resolve terser-webpack-plugin to 5.4.0. Remove the transitive serialize-javascript@6.0.2 dependency from the front-end lockfile. Remove the now unused transitive randombytes entry that came from serialize-javascript.
Checklist
self-explanatory (or properly documented)
Testing instructions