Skip to content

Fix TestNewShellHandler to use raw byte streams #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KCarretto merged 1 commit into from
Dec 21, 2025
Merged

Fix TestNewShellHandler to use raw byte streams #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tavern/internal/http/stream/websocket_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,11 @@ func TestNewShellHandler(t *testing.T) {
_, p, err := ws.ReadMessage()
assert.NoError(t, err)

expectedJSON := `{"type":"data","data":"aGVsbG8gZnJvbSBzZXJ2ZXI="}` // base64 "hello from server"
assert.Equal(t, []byte(expectedJSON), p)
assert.Equal(t, testMessage, p)

// Test reading from the websocket (shell -> server)
// Client sends JSON
readMessage := []byte(`{"type":"data","data":"aGVsbG8gZnJvbSBzaGVsbA=="}`) // base64 "hello from shell"
// Client sends raw bytes
readMessage := []byte("hello from shell")
err = ws.WriteMessage(websocket.TextMessage, readMessage)
require.NoError(t, err)

Expand All @@ -118,7 +117,7 @@ func TestNewShellHandler(t *testing.T) {
require.NoError(t, err, "timed out waiting for message from websocket")

// The body sent to pubsub should be the raw bytes
assert.Equal(t, []byte("hello from shell"), msg.Body)
assert.Equal(t, readMessage, msg.Body)
assert.Equal(t, "data", msg.Metadata[stream.MetadataMsgKind])
msg.Ack()
}