Tests: Coverage Expansion and Refinement#1378
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Couple things seem sus like the git history is borked.
The new tests look good tho
.devcontainer/devcontainer.json
Outdated
| }, | ||
| "ghcr.io/devcontainers/features/rust:1": { | ||
| "version": "1.91.1", | ||
| "version": "1.87", |
docs/_docs/user-guide/imix.md
Outdated
| cd realm/implants/imix/ | ||
| # Tell the linker to use the MacOSX.sdk | ||
| export SDKROOT="/MacOSX.sdk/"; export RUSTFLAGS="-Clink-arg=-isysroot -Clink-arg=/MacOSX.sdk -Clink-arg=-F/MacOSX.sdk/System/Library/Frameworks -Clink-arg=-L/MacOSX.sdk/usr/lib -Clink-arg=-lresolv" | ||
| export RUSTFLAGS="-Clink-arg=-isysroot -Clink-arg=/MacOSX.sdk -Clink-arg=-F/MacOSX.sdk/System/Library/Frameworks -Clink-arg=-L/MacOSX.sdk/usr/lib -Clink-arg=-lresolv" |
There was a problem hiding this comment.
It looks like the branch is maybe out of date?
|
Somehow jules got way out of date |
I have merged the latest changes from main and verified that my tests still pass. I am now up to date. |
3 participants
Added comprehensive slicing tests for Eldritch DSL covering edge cases. Added context edge case tests for Tavern auth module.
Stability Report:
implants/lib/eldritchv2/eldritch-core/tests/slicing_coverage.rspassed 20x consecutive runs.tavern/internal/auth/context_edge_cases_test.gopassed 20x consecutive runs.PR created automatically by Jules for task 9478969234861993445 started by @KCarretto