Skip to content

Fix flaky TestMuxHistoryOrdering test#1433

Merged
KCarretto merged 1 commit intomainfrom
fix-flaky-mux-ordering-test-4391622681074417945
Dec 28, 2025
Merged

Fix flaky TestMuxHistoryOrdering test#1433
KCarretto merged 1 commit intomainfrom
fix-flaky-mux-ordering-test-4391622681074417945

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

Fixed a race condition in TestMuxHistoryOrdering where sending messages too quickly could cause the stream buffer to initialize incorrectly or timeout.

Changes:

  • Split the message sending loop.
  • Explicitly wait for the "Anchor" message (index 0) to be received before sending the rest.
  • Retained the core test logic verifying that out-of-order messages (C, then B) are correctly reordered (B, then C).

PR created automatically by Jules for task 4391622681074417945 started by @KCarretto

…sed first

Refactored the `TestMuxHistoryOrdering` test to explicitly wait for the anchor message ("A") to be processed and received by the monitor stream before sending subsequent out-of-order messages. This eliminates the race condition where the stream initialization might be delayed, causing unexpected buffering behavior or timeouts. The test logic for verifying out-of-order reassembly (C arriving before B) remains intact.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2735    ±0 2735    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#69 2735 2735 0 0 0 0 28.2s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2735 0 0 43.1s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 39.4s 43.1s
eldritch: random::string_impl::tests::test_string_uniform 3 39.4s 43.1s
eldritch: random::string_impl::tests::test_string_uniform 3 39.4s 43.1s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.5s 6.2s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.5s 6.2s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.5s 6.2s
eldritch: random::string_impl::tests::test_string_length 3 5.7s 6.0s
eldritch: random::string_impl::tests::test_string_length 3 5.7s 6.0s
eldritch: random::string_impl::tests::test_string_length 3 5.7s 6.0s
eldritch: sys::dll_reflect_impl::tests::test_dll_reflect_starlark 1 5.4s 5.4s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review December 28, 2025 00:06
@KCarretto KCarretto requested review from Cictrone and hulto December 28, 2025 00:06
@KCarretto KCarretto merged commit 177ae9b into main Dec 28, 2025
7 checks passed
@KCarretto KCarretto deleted the fix-flaky-mux-ordering-test-4391622681074417945 branch December 28, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants