Skip to content

fix(ci): remove unnecessary Node.js setup from implants job#1434

Merged
hulto merged 3 commits intomainfrom
claude/resolve-issue-1432-O6NTH
Dec 28, 2025
Merged

fix(ci): remove unnecessary Node.js setup from implants job#1434
hulto merged 3 commits intomainfrom
claude/resolve-issue-1432-O6NTH

Conversation

@hulto
Copy link
Copy Markdown
Collaborator

@hulto hulto commented Dec 27, 2025

Node.js is not needed for implant tests. The GitHub Actions runners come
with Node.js pre-installed, so the npx command used in the CTRF conversion
step will work without explicitly setting up Node.js.

Fixes #1432

Node.js is not needed for implant tests. The GitHub Actions runners come
with Node.js pre-installed, so the npx command used in the CTRF conversion
step will work without explicitly setting up Node.js.

Fixes #1432
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 27, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2744    ±0 2744    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#84 2744 2744 0 0 0 0 26.6s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2744 0 0 43.1s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 39.3s 43.1s
eldritch: random::string_impl::tests::test_string_uniform 3 39.3s 43.1s
eldritch: random::string_impl::tests::test_string_uniform 3 39.3s 43.1s
eldritch: process::info_impl::tests::test_info_default 3 3.1s 9.0s
eldritch: process::info_impl::tests::test_info_default 3 3.1s 9.0s
eldritch: process::info_impl::tests::test_info_default 3 3.1s 9.0s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.7s 8.1s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.7s 8.1s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.7s 8.1s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.0s 8.1s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto self-requested a review December 28, 2025 00:29
@hulto hulto merged commit 140eca3 into main Dec 28, 2025
10 of 11 checks passed
@hulto hulto deleted the claude/resolve-issue-1432-O6NTH branch December 28, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] implants jobs install node js

3 participants