Skip to content

[Tavern] Post-MVP Refactor#147

Merged
KCarretto merged 13 commits intomainfrom
ists-followups
Mar 22, 2023
Merged

[Tavern] Post-MVP Refactor#147
KCarretto merged 13 commits intomainfrom
ists-followups

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

Implements some features based on #144

  • Requires Agent to send hostPlatform during claim tasks mutation
  • Enables Agent to send hostPrimaryIP during claim tasks mutation (if available)
  • Renames tome.parameters to tome.paramdefs
  • Overhauled Tavern Authentication, especially for when authentication is disabled
  • Added Creator edge to jobs (if available)
  • Updates Environment configuration, enabled DB Limits to be set via environment variables

Which issue(s) this PR fixes:

Fixes #132
Fixes #133
Fixes #134
Fixes #136

@KCarretto KCarretto requested a review from hulto March 8, 2023 03:05
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2023

Codecov Report

Merging #147 (fa13d24) into main (33d4eff) will increase coverage by 2.02%.
The diff coverage is 57.62%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   54.15%   56.17%   +2.02%     
==========================================
  Files          27       28       +1     
  Lines        1313     1376      +63     
==========================================
+ Hits          711      773      +62     
+ Misses        531      522       -9     
- Partials       71       81      +10     
Impacted Files Coverage Δ
tavern/auth/context.go 0.00% <0.00%> (ø)
tavern/auth/middleware.go 0.00% <0.00%> (ø)
tavern/graphql/ent.resolvers.go 20.00% <ø> (ø)
tavern/graphql/mutation.resolvers.go 62.26% <ø> (+2.26%) ⬆️
tavern/graphql/query.resolvers.go 33.33% <ø> (ø)
tavern/ent/schema/job.go 36.17% <14.28%> (-5.30%) ⬇️
tavern/env.go 63.15% <63.15%> (ø)
tavern/config.go 65.68% <66.66%> (+27.68%) ⬆️
tavern/app.go 56.52% <100.00%> (-0.38%) ⬇️
tavern/auth/oauth.go 66.66% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Milkshak3s Milkshak3s added cleanup Code cleanup and tech debt removal api-change labels Mar 16, 2023
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KCarretto KCarretto merged commit c17d83e into main Mar 22, 2023
@KCarretto KCarretto deleted the ists-followups branch March 22, 2023 22:20
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
[Tavern] Post-MVP Refactor (#147)

* updated env vars for config, added new env vars and related docs

* tome.parameters --> tome.paramdefs

* Refactoring auth

* Refactoring auth

* Upgrade go to 1.20

* Added HostPlatform and HostPrimaryIP information for sessions

* Fixed entgo naming conventions; should be snake_case for field definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change cleanup Code cleanup and tech debt removal

Projects

None yet

3 participants