Skip to content

Support separate error channel in StreamPrinter for imix#1821

Merged
KCarretto merged 3 commits intomainfrom
imix-streamprinter-error-tx-6216986745705561755
Feb 22, 2026
Merged

Support separate error channel in StreamPrinter for imix#1821
KCarretto merged 3 commits intomainfrom
imix-streamprinter-error-tx-6216986745705561755

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

@KCarretto KCarretto commented Feb 16, 2026

Updated StreamPrinter in imix to support a separate error channel (error_tx). This allows output from eprint! (and equivalent Eldritch built-ins) to be captured and reported as TaskErrors in the TaskOutput structure, rather than being mixed with standard output. A new test case confirms that eprint messages are correctly routed to the error field.

image

PR created automatically by Jules for task 6216986745705561755 started by @KCarretto

- Add `error_tx` to `StreamPrinter` to handle error messages separately.
- Update `execute_task` to create an error channel and pass it to `StreamPrinter` and `spawn_output_consumer`.
- Refactor `spawn_output_consumer` to use `tokio::select!` for handling both output and error streams concurrently.
- Wrap error messages in `TaskError` when reporting to C2.
- Add `test_task_eprint_behavior` to verify `eprint` functionality.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 16, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2615    ±0 2615    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1041 2615 2615 0 0 0 0 36.2s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2615 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestDockerExecutor_Build_ContextCancellation 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.5s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.5s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.5s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review February 22, 2026 02:39
@KCarretto KCarretto enabled auto-merge February 22, 2026 02:46
@KCarretto KCarretto requested a review from hulto February 22, 2026 02:46
@KCarretto KCarretto added this pull request to the merge queue Feb 22, 2026
Merged via the queue into main with commit 2ec7543 Feb 22, 2026
8 checks passed
@KCarretto KCarretto deleted the imix-streamprinter-error-tx-6216986745705561755 branch February 22, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants