host_unique: add build.rs and IMIX_UNIQUE selector config#1875
Merged
Conversation
Add a build.rs that reads IMIX_UNIQUE at compile time, validates it as JSON, and bakes the value into the binary via cargo:rustc-env. Add #[derive(Serialize, Deserialize)] to each selector struct (Env, File, MacAddr, Registry) so their fields serve directly as the JSON arg payload — no separate args types required. Introduce SelectorSpec, a serde-tagged enum with "type"/"arg" keys that maps each type string to the corresponding selector struct. Adding a new selector only requires deriving Serialize/Deserialize on the struct and adding one variant; serde handles JSON marshaling automatically. Expose from_imix_unique() which deserialises the baked-in IMIX_UNIQUE value into an ordered Vec<Box<dyn HostIDSelector>>, returning None when the variable was not set so callers can fall back to defaults(). https://claude.ai/code/session_01Nsm57Cbikgtzf2nfem9tFX
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
KCarretto
previously approved these changes
Feb 23, 2026
Cictrone
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #