Skip to content

fix(www): allow committing build artifacts and simplify embed directive#1876

Merged
KCarretto merged 1 commit intomainfrom
fix-frontend-build-embed-15740604039805952117
Feb 23, 2026
Merged

fix(www): allow committing build artifacts and simplify embed directive#1876
KCarretto merged 1 commit intomainfrom
fix-frontend-build-embed-15740604039805952117

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This PR fixes a recurring build issue where go build fails due to missing or mismatched frontend build artifacts.

Changes:

  1. tavern/internal/www/.gitignore: Added !/build to ensure the build directory is tracked by git. This allows the frontend artifacts to be committed, so go build works out-of-the-box without requiring npm run build in fresh checkouts.
  2. tavern/internal/www/http.go: Changed the //go:embed directive from a list of glob patterns (build/*.html, build/*.png, etc.) to //go:embed build. This recursively embeds the entire build directory, which is simpler and more robust (e.g., it now includes site.webmanifest which was previously missed, and won't fail if .ico files are absent).

Verified by running go build ./tavern successfully.


PR created automatically by Jules for task 15740604039805952117 started by @KCarretto

- Updates `tavern/internal/www/.gitignore` to explicitly allow `build/` directory, ensuring build artifacts are committed and available for Go build.
- Updates `tavern/internal/www/http.go` to use `//go:embed build` directive, recursively embedding the entire `build` directory. This is more robust than embedding specific file patterns and prevents build failures if file types change or are missing.
- Resolves build error "pattern build/*.html: no matching files found".

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@KCarretto KCarretto marked this pull request as ready for review February 23, 2026 05:29
@KCarretto KCarretto requested a review from Cictrone February 23, 2026 05:29
@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2658    ±0 2658    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1149 2658 2658 0 0 0 0 38.0s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2658 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 14667d3 Feb 23, 2026
9 checks passed
@KCarretto KCarretto deleted the fix-frontend-build-embed-15740604039805952117 branch February 23, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants