Conversation
- Updates `tavern/internal/www/.gitignore` to explicitly allow `build/` directory, ensuring build artifacts are committed and available for Go build. - Updates `tavern/internal/www/http.go` to use `//go:embed build` directive, recursively embedding the entire `build` directory. This is more robust than embedding specific file patterns and prevents build failures if file types change or are missing. - Resolves build error "pattern build/*.html: no matching files found". Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This PR fixes a recurring build issue where
go buildfails due to missing or mismatched frontend build artifacts.Changes:
tavern/internal/www/.gitignore: Added!/buildto ensure thebuilddirectory is tracked by git. This allows the frontend artifacts to be committed, sogo buildworks out-of-the-box without requiringnpm run buildin fresh checkouts.tavern/internal/www/http.go: Changed the//go:embeddirective from a list of glob patterns (build/*.html,build/*.png, etc.) to//go:embed build. This recursively embeds the entirebuilddirectory, which is simpler and more robust (e.g., it now includessite.webmanifestwhich was previously missed, and won't fail if.icofiles are absent).Verified by running
go build ./tavernsuccessfully.PR created automatically by Jules for task 15740604039805952117 started by @KCarretto