Implement file chunking for report.file in Eldritch#1887
Conversation
Updated `Agent` trait to support streaming file upload using `Iterator`. Implemented `FileChunkIterator` in `eldritch-libreport` to read files in 1MB chunks. Updated `ImixAgent` to stream chunks to transport using a background thread and bounded channel. Updated mock and fake agents to match the new `Agent` trait signature. Added integration test `test_report_large_file_via_eldritch` to verify 100MB file upload behavior. This prevents memory issues when uploading large files. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Ran `cargo fmt` in `implants/` directory to fix CI failure. Also verified that the new test `test_report_large_file_via_eldritch` still passes. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Changed `Agent::report_file` to accept `std::sync::mpsc::Receiver` instead of `Iterator`. Updated `eldritch-libreport` to spawn a thread and feed the channel. Updated `ImixAgent` to pass the receiver to transport. Updated tests and mocks. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
2 participants
Implement file chunking for report.file in Eldritch to prevent memory issues with large files.
Updated Agent trait in eldritch-agent to support streaming via Iterator. Implement FileChunkIterator in eldritch-libreport with 1MB chunk size. Update ImixAgent to stream chunks to transport using a background thread. Update mocks and fake implementations in eldritch-libagent, eldritch-libassets, eldritch-libpivot, and tests. Add integration test test_report_large_file_via_eldritch in imix to verify 100MB file upload behavior.
If we fail to upload for any reason, report the error.
PR created automatically by Jules for task 15820419166954838064 started by @KCarretto