Skip to content

feat: Change ShellTask input/output/error to Text for large payloads#1899

Merged
KCarretto merged 3 commits intomainfrom
shell-task-large-text-1032451398280575890
Feb 25, 2026
Merged

feat: Change ShellTask input/output/error to Text for large payloads#1899
KCarretto merged 3 commits intomainfrom
shell-task-large-text-1032451398280575890

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Updated ShellTask schema to use field.Text for input, output, and error fields to support much longer length. Regenerated Ent code and GraphQL schema. Added verification test.


PR created automatically by Jules for task 1032451398280575890 started by @KCarretto

Updated ShellTask schema to use field.Text for input, output, and error fields to support much longer length. Regenerated Ent code and GraphQL schema. Added verification test.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@KCarretto KCarretto marked this pull request as ready for review February 25, 2026 01:25
@KCarretto
Copy link
Copy Markdown
Collaborator Author

image Fixed

@google-labs-jules
Copy link
Copy Markdown
Contributor

image Fixed

Glad to see it working as expected!

Updated ShellTask schema to use field.Text for input, output, and error fields to support much longer length. Regenerated Ent code and GraphQL schema. Added verification test.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2659    ±0 2659    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1236 2659 2659 0 0 0 0 37.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2659 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
TestDockerExecutor_Build_SimpleEcho 1 3.2s 3.2s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Updated ShellTask schema to use LONGTEXT for input, output, and error fields to support very large payloads (>64KB).
Regenerated Ent code and GraphQL schema.
Added verification test with 70KB payload.
Updated Portal schema comment to ensuring file inclusion.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto added this pull request to the merge queue Feb 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 25, 2026
@KCarretto KCarretto added this pull request to the merge queue Feb 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 25, 2026
@KCarretto KCarretto added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit 2d3d016 Feb 25, 2026
9 checks passed
@KCarretto KCarretto deleted the shell-task-large-text-1032451398280575890 branch February 25, 2026 04:48
Cictrone added a commit that referenced this pull request Feb 25, 2026
…1899)

* feat: Change ShellTask input/output/error to Text for large payloads

Updated ShellTask schema to use field.Text for input, output, and error fields to support much longer length. Regenerated Ent code and GraphQL schema. Added verification test.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>

* feat: Change ShellTask input/output/error to Text for large payloads

Updated ShellTask schema to use field.Text for input, output, and error fields to support much longer length. Regenerated Ent code and GraphQL schema. Added verification test.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>

* feat: Change ShellTask input/output/error to LONGTEXT

Updated ShellTask schema to use LONGTEXT for input, output, and error fields to support very large payloads (>64KB).
Regenerated Ent code and GraphQL schema.
Added verification test with 70KB payload.
Updated Portal schema comment to ensuring file inclusion.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants