Skip to content

feat(shellv2): handle late beacon checkin in UI#1911

Merged
KCarretto merged 4 commits intomainfrom
shellv2-late-checkin-ui-18014522677988305833
Feb 26, 2026
Merged

feat(shellv2): handle late beacon checkin in UI#1911
KCarretto merged 4 commits intomainfrom
shellv2-late-checkin-ui-18014522677988305833

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This PR updates the ShellV2 interface to visually indicate when a beacon is more than 5 minutes late to check in. It greys out the terminal text and disables user input to prevent confusion or wasted effort on a disconnected session.

Changes:

  • Modified useCallbackTimer hook to calculate isLateCheckin status based on a 5-minute threshold.
  • Updated useShellTerminal hook to accept isLateCheckin status.
  • Implemented logic in useShellTerminal to dynamically change the xterm theme (grey foreground) and block input events when the beacon is late.
  • Added a unit test suite for useCallbackTimer to verify time calculation logic.

PR created automatically by Jules for task 18014522677988305833 started by @KCarretto

- Update `useCallbackTimer` to track `isLateCheckin` (> 5 mins late).
- Pass `isLateCheckin` to `useShellTerminal`.
- In `useShellTerminal`, update xterm theme to grey out foreground and disable input when late.
- Add unit tests for `useCallbackTimer`.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2686    ±0 2686    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1298 2686 2686 0 0 0 0 30.1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2686 0 0 6.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.2s 6.2s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
TestDockerExecutor_Build_SimpleEcho 1 3.4s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review February 26, 2026 05:08
Cictrone
Cictrone previously approved these changes Feb 26, 2026
@KCarretto KCarretto enabled auto-merge February 26, 2026 05:08
@KCarretto KCarretto added this pull request to the merge queue Feb 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 26, 2026
@KCarretto KCarretto added this pull request to the merge queue Feb 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 26, 2026
@KCarretto KCarretto merged commit 8444044 into main Feb 26, 2026
8 checks passed
@KCarretto KCarretto deleted the shellv2-late-checkin-ui-18014522677988305833 branch February 26, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants