feat(shellv2): handle late beacon checkin in UI#1911
Conversation
- Update `useCallbackTimer` to track `isLateCheckin` (> 5 mins late). - Pass `isLateCheckin` to `useShellTerminal`. - In `useShellTerminal`, update xterm theme to grey out foreground and disable input when late. - Add unit tests for `useCallbackTimer`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This PR updates the ShellV2 interface to visually indicate when a beacon is more than 5 minutes late to check in. It greys out the terminal text and disables user input to prevent confusion or wasted effort on a disconnected session.
Changes:
useCallbackTimerhook to calculateisLateCheckinstatus based on a 5-minute threshold.useShellTerminalhook to acceptisLateCheckinstatus.useShellTerminalto dynamically change the xterm theme (grey foreground) and block input events when the beacon is late.useCallbackTimerto verify time calculation logic.PR created automatically by Jules for task 18014522677988305833 started by @KCarretto