Skip to content

Add Shells tab to Host Details page#1913

Merged
KCarretto merged 3 commits intomainfrom
feat/host-details-shell-tab-11795586815061751570
Feb 26, 2026
Merged

Add Shells tab to Host Details page#1913
KCarretto merged 3 commits intomainfrom
feat/host-details-shell-tab-11795586815061751570

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Implements a new Shells tab in the Host Details page, displaying a list of shells associated with the host. The tab includes shell status, usage count, creator, active users, and a connect button.


PR created automatically by Jules for task 11795586815061751570 started by @KCarretto

- Create `shell-tab` directory with `ShellTab`, `ShellsTable`, `useShellIds`, `types`, and `queries`.
- Update `HostDetails.tsx` to include the new tab.
- Update `HostTabs.tsx` to display active/total shell counts.
- Add `GET_HOST_SHELL_COUNT` query.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2682    ±0 2682    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1299 2682 2682 0 0 0 0 30.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2682 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
TestDockerExecutor_Build_SimpleEcho 1 3.5s 3.5s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

- Update `ShellsTable.tsx` to correctly extract shell data from `ShellsQueryTopLevel`
- Update `extractData` function to access `response.shells.edges` instead of `response.edges`
- Ensure type safety by using correct interfaces for `VirtualizedTable`
- Verified fix with Playwright simulation showing populated table rows

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto
Copy link
Copy Markdown
Collaborator Author

image looks good

@KCarretto KCarretto marked this pull request as ready for review February 26, 2026 05:50
@KCarretto KCarretto enabled auto-merge February 26, 2026 06:02
@KCarretto KCarretto added this pull request to the merge queue Feb 26, 2026
@KCarretto KCarretto removed this pull request from the merge queue due to a manual request Feb 26, 2026
@KCarretto KCarretto added this pull request to the merge queue Feb 26, 2026
@KCarretto KCarretto removed this pull request from the merge queue due to a manual request Feb 26, 2026
@KCarretto KCarretto merged commit db1cccf into main Feb 26, 2026
9 checks passed
@KCarretto KCarretto deleted the feat/host-details-shell-tab-11795586815061751570 branch February 26, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants