Skip to content

feat: Add python syntax highlighting to ShellV2#1927

Merged
KCarretto merged 2 commits intomainfrom
shellv2-syntax-highlighting-15972764486569407497
Feb 27, 2026
Merged

feat: Add python syntax highlighting to ShellV2#1927
KCarretto merged 2 commits intomainfrom
shellv2-syntax-highlighting-15972764486569407497

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Implemented a regex-based Python syntax highlighter in shellUtils.ts and integrated it into useShellTerminal.ts.

  • Highlights keywords (Magenta), strings (Green), comments (Grey), and numbers (Yellow).
  • Updated redrawLine to apply highlighting to the input buffer.
  • Removed "fast path" optimizations in onData to ensure highlighting updates on every keystroke.
  • Added comprehensive unit tests in shellUtils.test.ts.
  • Updated frontend build artifacts (tavern/internal/www/build/) as they are tracked in the repository.

PR created automatically by Jules for task 15972764486569407497 started by @KCarretto

- Implemented `highlightPythonSyntax` in `shellUtils.ts` using regex to tokenize and colorize Python code with ANSI escape codes.
- Integrated highlighting into `useShellTerminal.ts` `redrawLine` function.
- Removed optimization fast-paths in `onData` to force redraw and highlighting update on every input event.
- Added unit tests for syntax highlighting logic.
- Updated frontend build artifacts to reflect changes.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2698    ±0 2698    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1320 2698 2698 0 0 0 0 44.3s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2698 0 0 5.7s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.7s 5.7s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 26, 2026 23:52
@KCarretto KCarretto enabled auto-merge February 26, 2026 23:52
@KCarretto
Copy link
Copy Markdown
Collaborator Author

image looks good to me!

@google-labs-jules
Copy link
Copy Markdown
Contributor

image looks good to me!

Thanks for the verification! Glad it looks good.

- Implemented `highlightPythonSyntax` in `shellUtils.ts` using regex to tokenize and colorize Python code with ANSI escape codes.
- Integrated highlighting into `useShellTerminal.ts` `redrawLine` function.
- Removed optimization fast-paths in `onData` to force redraw and highlighting update on every input event.
- Added unit tests for syntax highlighting logic.
- Updated frontend build artifacts to reflect changes.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto disabled auto-merge February 27, 2026 00:12
@KCarretto KCarretto merged commit 6a73399 into main Feb 27, 2026
8 checks passed
@KCarretto KCarretto deleted the shellv2-syntax-highlighting-15972764486569407497 branch February 27, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant