Fix shell macro ! parsing error in ShellV2 UI#1929
Conversation
- Modified `implants/lib/eldritch/eldritch-wasm/src/headless.rs` to intercept `!` commands in `input` handler.
- Implemented `expand_macros` helper that uses `Lexer` to identify `!` syntax errors (which correspond to macros) and transforms them into valid Eldritch code: `import sys; _cmd_res = sys.shell("..."); print(_cmd_res['stdout']); print(_cmd_res['stderr'])`.
- This ensures the agent receives valid code while the UI history retains the user's original `!` command.
- Added unit tests for macro expansion in `headless.rs`.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
1 participant
The
!macro in the shell UI was failing due to a parsing error because the Eldritch lexer treated it as invalid syntax. This change implements a pre-processing step in the WASM headless REPL to detect lines starting with!(using the Lexer's error reporting) and expand them into asys.shell(...)call sequence that prints stdout and stderr. This allows users to execute shell commands using the!shorthand.PR created automatically by Jules for task 14304265154477813625 started by @KCarretto