Track active users on shell via websocket#1930
Conversation
This commit updates the Shell WebSocket handler to track active users on the shell. When a user connects to the shell via WebSocket, they are added to the `active_users` edge of the Shell entity. A background goroutine polls every 10 seconds to ensure the user remains in the list (handling potential race conditions or external removals). When the WebSocket connection closes, the user is removed from the list. This ensures that the "Active Users" list in the UI accurately reflects who is currently viewing/interacting with the shell, even across multiple Tavern instances. Changes: - Modified `tavern/internal/http/shell/handler.go` to add `manageUserPresence` method. - Added `TestShellActiveUsers` to `tavern/internal/http/shell/integration_test.go` to verify the behavior. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
Track active users on shell via websocket by adding them to the
active_usersedge of the Shell entity on connection, polling to maintain presence, and removing them on disconnection.PR created automatically by Jules for task 1284810859092603002 started by @KCarretto