Persist ShellV2 History to LocalStorage#1934
Conversation
This change updates the ShellV2 frontend to save and load command history from the browser's localStorage. This ensures that users retain their command history across page reloads and session restarts. Key changes: - Added `loadHistory` and `saveHistory` utilities in `shellUtils.ts`. - `saveHistory` caps the history at 1000 entries to manage storage size. - Integrated these utilities into `useShellTerminal.ts` to load history on initialization and save it upon command execution. - Added comprehensive unit tests for history persistence logic. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
KCarretto
deleted the
shellv2-history-persistence-3400681648289637588
branch
1 participant
Implemented local storage persistence for shell command history. Added load/save utility functions with a 1000-entry cap and integrated them into the shell terminal hook. Verified with unit tests.
PR created automatically by Jules for task 3400681648289637588 started by @KCarretto