Skip to content

Optimize ShellV2 terminal input handling#1936

Merged
KCarretto merged 4 commits intomainfrom
shellv2-input-optimization-8723481768795692919
Feb 27, 2026
Merged

Optimize ShellV2 terminal input handling#1936
KCarretto merged 4 commits intomainfrom
shellv2-input-optimization-8723481768795692919

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This PR addresses a performance regression in the ShellV2 terminal where every keystroke triggered a full line redraw, causing input lag.

Changes:

  • Modified useShellTerminal.ts to include a 'fast path' for common input scenarios (appending characters and backspacing at the end of the line).
  • In the fast path, characters are written directly to the xterm.js instance, and a full redraw (for syntax highlighting) is debounced by 50ms.
  • Complex edits (insertion/deletion in the middle of a line) continue to trigger an immediate redraw to ensure correctness.

Verification:

  • Ran existing unit tests for shellUtils and useCallbackTimer (passed).
  • Created a Playwright script (verify_shell.py) to simulate user input and verify the terminal UI renders correctly without errors.
  • Visual verification via screenshot confirms the terminal prompt and input appear as expected.

PR created automatically by Jules for task 8723481768795692919 started by @KCarretto

- Implemented fast-path logic in `useShellTerminal` for character appending and backspacing at the end of the line.
- Introduced `redrawTimeoutRef` and `scheduleRedraw` to debounce full line redraws, significantly improving input smoothness.
- Maintained existing syntax highlighting and word navigation functionality.
- Verified changes with Playwright integration tests and existing unit tests for helper functions.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules bot and others added 3 commits February 27, 2026 03:08
- Updated `redrawLine` in `useShellTerminal.ts` to calculate visual line counts using `term.cols`.
- Ensures long input lines wrap naturally without duplicating content above the current line.
- Verified with Playwright wrapping tests.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto marked this pull request as ready for review February 27, 2026 03:24
@KCarretto KCarretto merged commit 70ec942 into main Feb 27, 2026
5 of 8 checks passed
@KCarretto KCarretto deleted the shellv2-input-optimization-8723481768795692919 branch February 27, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant