Optimize ShellV2 terminal input handling#1936
Conversation
- Implemented fast-path logic in `useShellTerminal` for character appending and backspacing at the end of the line. - Introduced `redrawTimeoutRef` and `scheduleRedraw` to debounce full line redraws, significantly improving input smoothness. - Maintained existing syntax highlighting and word navigation functionality. - Verified changes with Playwright integration tests and existing unit tests for helper functions. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated `redrawLine` in `useShellTerminal.ts` to calculate visual line counts using `term.cols`. - Ensures long input lines wrap naturally without duplicating content above the current line. - Verified with Playwright wrapping tests. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
This PR addresses a performance regression in the ShellV2 terminal where every keystroke triggered a full line redraw, causing input lag.
Changes:
useShellTerminal.tsto include a 'fast path' for common input scenarios (appending characters and backspacing at the end of the line).Verification:
shellUtilsanduseCallbackTimer(passed).verify_shell.py) to simulate user input and verify the terminal UI renders correctly without errors.PR created automatically by Jules for task 8723481768795692919 started by @KCarretto